jmoiron plays the blues
Argent-Matter/gcyr
·
PR #123
·
jm/landing-rework → 1.20.1
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - It's called [by the scanning machine](https://github.com/Argent-Matter/gcyr/pull/123/changes#diff-bb...
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - instead of just doing this piecemeal I got rid of all of the quadratic behavior from `addBlock`; ent...
Arborsm/GT-- created comment on issue #72: fix early load of emi mixin that crashes emi > 1.1.22 - can you take another look
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - why: i worked on telemetry storage for ~7y and float is my enemy
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - just messy merge, swapped to f for all instances
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - i don't think that `resolveSelectedFuelRecipe` runs on every tick, it only runs when the recipe does...
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - This is probably true but I think that requires a bunch of extra work for eg. recipe viewer support....
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - Removed `IRocketPart` from the landing module to prevent this. The seat isn't a rocket part either s...
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - Yeah it's slightly more interesting if it isn't a strict upgrade.
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - Going to use `gtceu.universal.tooltip.fluid_storage_capacity` instead of making my own copy.
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - I didn't add a texture for this, in two minds about whether this should be a block or maybe an optio...
Argent-Matter/gcyr commented review on PR #123:
Argent-Matter/gcyr created review comment on PR #123: - made this a normal property of the rocket motor type
Argent-Matter/gcyr commented review on PR #123: